FIXME on ExPolygon::overlaps(), which should be commutative.

2026-07-03 17:05:43 +02:00 · 2021-01-22 15:32:36 +01:00
parent 59017a7dae
commit eef800b5c4
2 changed files with 3 additions and 2 deletions
--- a/src/libslic3r/SLA/SupportPointGenerator.hpp
+++ b/src/libslic3r/SLA/SupportPointGenerator.hpp
@@ -84,6 +84,7 @@ public:
        float                                   overhangs_area = 0.f;
        
        bool overlaps(const Structure &rhs) const { 
+            //FIXME ExPolygon::overlaps() shall be commutative, it is not!
            return this->bbox.overlap(rhs.bbox) && (this->polygon->overlaps(*rhs.polygon) || rhs.polygon->overlaps(*this->polygon)); 
        }
        float overlap_area(const Structure &rhs) const {